Add Python3 compatibility + a few minor changes#86
Open
deliberist wants to merge 3 commits intoHoverHell:masterfrom
deliberist:master
Open
Add Python3 compatibility + a few minor changes#86deliberist wants to merge 3 commits intoHoverHell:masterfrom deliberist:master
deliberist wants to merge 3 commits intoHoverHell:masterfrom
deliberist:master
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I love you project! I needed the exact same thing to use images from Reddit as desktop wallpapers, but I'm running a system without Python2. I updated the code so that it can run under Python3. I do not believe I broke anything if yourself (or anyone else) has to still run the code with Python2. But I was not able to test that (sorry!).
If interested, I use this script to update my wallpaper given that all my downloaded Reddit pics are in a "backgrounds" directory in the RedditImageGrab project.
Feel free to reject the pull-request if something is broken when running with Python2 and I'll look into fixing it.
Thanks! And again, great project!